search

kube-object-storage / lib-bucket-provisioner

Library for the dynamic provisioning of object store buckets to be used by object store providers.
Apache License 2.0
21 stars 22 forks source link

Fix OB empty check during provisioning #205

Closed BlaineEXE closed 3 years ago

BlaineEXE commented 3 years ago

Fix the existing check for an OB empty struct by using k8s api's semantic deep-equality methods. Previously, this was a pointer equality check and not a valid check for an empty struct. The k8s code generator does not generate == or other equality methods for generated types that might have been able to be used.

Signed-off-by: Blaine Gardner blaine.gardner@redhat.com

Fixes #203

Ping @jeffvance to review without any rush.

Changes to go mod files are due to running go mod tidy after adding the new reference to a new k8s api machinery lib.

jeffvance commented 3 years ago

LGTM. Would you mind adding a comment as to why the generated DeepEqual and the golang reflect.DeepEqual cannot be used?