Fix broken test and report CI failing correctly

kube-object-storage / lib-bucket-provisioner

Library for the dynamic provisioning of object store buckets to be used by object store providers.

Apache License 2.0

20 stars 22 forks source link

Fix broken test and report CI failing correctly #207

Open toshipp opened 3 years ago

toshipp commented 3 years ago

Because the script hack/go.sh ci-checks does not report its failure by the exit code, we can not notice a CI failure. This fixes the issue and also fixes found broken tests.

Signed-off-by: Toshikuni Fukaya toshikuni-fukaya@cybozu.co.jp

satoru-takeuchi commented 3 years ago

LGTM

toshipp commented 3 years ago

Could someone review this?

satoru-takeuchi commented 3 years ago

Could some one take a look at this PR? It's a small PR and we can't detect some CI failures without applying it.

guymguym commented 3 years ago

@jeffvance @copejon ?