fix updating labels and finalizers

kube-object-storage / lib-bucket-provisioner

Library for the dynamic provisioning of object store buckets to be used by object store providers.

Apache License 2.0

20 stars 22 forks source link

fix updating labels and finalizers #208

Closed llamerada-jp closed 3 years ago

llamerada-jp commented 3 years ago

fix issue https://github.com/kube-object-storage/lib-bucket-provisioner/issues/206

merge and set labels and finalizer to OBC

Signed-off-by: Toshikuni Fukaya toshikuni-fukaya@cybozu.co.jp Signed-off-by: H.Muraoka hiroshi-muraoka@cybozu.co.jp

llamerada-jp commented 3 years ago

@BlaineEXE

This PR is ready for review. Would you assign reviewers?

BlaineEXE commented 3 years ago

I would like to see a commit body that explains what issue is fixed by the commit. Essentially, that labels and finalizers applied by the user to the OBC are overwritten by the lib.

I also want to wait on a review from @jeffvance. Once Jeff signs off, I can merge the PR.

jeffvance commented 3 years ago

/lgtm

BlaineEXE commented 3 years ago

@llamerada-jp now that this is merged, the next step is to include these changes into Rook by updating the go module reference.

toshipp commented 3 years ago

@BlaineEXE Thanks! I am a colleague of @llamerada-jp. We will send a PR to Rook project.