search

kube-object-storage / lib-bucket-provisioner

Library for the dynamic provisioning of object store buckets to be used by object store providers.
Apache License 2.0
20 stars 22 forks source link

fixed bug in generateBucketName #220

Closed dannyzaken closed 2 years ago

dannyzaken commented 2 years ago

when the prefix length is exactly maxBaseNameLen, the prefix is not truncated and as a result, the generated bucket name is invalid.

Signed-off-by: Danny Zaken dannyzaken@gmail.com

BlaineEXE commented 2 years ago

This looks good to me, but please clarify in the commit what exactly is making the generated name invalid. Is the generated name too long? Or is it an issue of not allowing multiple consecutive dashes? It's not fully clear to me.

BlaineEXE commented 2 years ago

I did confirm that this patch fixes the issue in Rook upstream, and I do believe this is length-related.