search

kube-object-storage / lib-bucket-provisioner

Library for the dynamic provisioning of object store buckets to be used by object store providers.
Apache License 2.0
20 stars 22 forks source link

fix nil pointer panic when changing bucket config #222

Closed degorenko closed 2 years ago

degorenko commented 2 years ago

Related-Issue: https://github.com/kube-object-storage/lib-bucket-provisioner/issues/219

Signed-off-by: Denis Egorenko degorenko@mirantis.com

BlaineEXE commented 2 years ago

I think this looks good. Would you describe the manual tests you used to test that the fix is working? I'd like to make sure there aren't any corner cases missed

degorenko commented 2 years ago

@BlaineEXE so, i did fork, made changes. But i'm currently using Rook 1.8.5, so i have to rebase on commit which is used in go.mod for 1.8.5 version. Finally, i have v0.0.0-20220105185820-c1da9586e05b plus that changes on top of it (I have additional config-override-1.8 branch in fork). Replaced in Rook go.mod l-b-p dependency on my fork commit, built Rook image on top of it and then test. So in my tests Rook 1.8.5+current change. Does it suites your expectations ?

BlaineEXE commented 2 years ago

I was thinking to look at the logs and make sure...

degorenko commented 2 years ago

rook-operator.log user-stats.log

degorenko commented 2 years ago

log contains some debug message around OBC spec diff, but it is not in current change, only for test purpose.

BlaineEXE commented 2 years ago

The tests look great. Thank you. I'm trying to figure out why the CI is failing though.

BlaineEXE commented 2 years ago

It looks like one of the tools used in CI is no longer hosted at the location.

This line in travis.yml needs updated: https://github.com/kube-object-storage/lib-bucket-provisioner/blob/4bea5edaff58c0e80e3ad0c56f2894a7d456cc87/.travis.yml#L18

Replacing that with this should get it going again I think.

curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/v1.16.0/install.sh | sh -s -- -b $(go env GOPATH)/bin && golangci-lint --version
BlaineEXE commented 2 years ago

Merged. To pull the change into Rook, we just need a PR that updates the go.mod to use the latest version (hash) of this library. And we can have it backported back to 1.8 and 1.9 as well. 👍 Thanks again!