use reclaimPolicy in delete choice

kube-object-storage / lib-bucket-provisioner

Library for the dynamic provisioning of object store buckets to be used by object store providers.

Apache License 2.0

21 stars 22 forks source link

use reclaimPolicy in delete choice #63

Closed jeffvance closed 5 years ago

jeffvance commented 5 years ago

Signed-off-by: jeffvance jeff.h.vance@gmail.com

Tested with s3 provisioner by creating an obc referencing a SC with reclaimPolicy=Retain then deleting the obc. ALl artifacts deleted and the bucket remained, per expectations. Changed SC's reclaimPolicy=Delete and bucket was deleted.

copejon commented 5 years ago

Changed SC's reclaimPolicy=Delete and bucket was deleted

This brings up a really important point. The SC should only prescribe the OB reclaim policy at point of inception. On deletes, the OB's reclaimPolicy should be the authoritative field for policy. Changes to the SC should not overrule policies of OBs created before the change.