search

kube-object-storage / lib-bucket-provisioner

Library for the dynamic provisioning of object store buckets to be used by object store providers.
Apache License 2.0
21 stars 22 forks source link

consider an /internal dir in repo #80

Closed jeffvance closed 5 years ago

jeffvance commented 5 years ago 
Use of /internal
The /internal package is woefully underused. I recommend both binaries and libraries take advantage of /internal to hide public functions that aren’t intended to be imported. Hiding your public import space also makes clearer which packages users should import and where to look for useful logic.

From: https://medium.com/@cep21/aspects-of-a-good-go-library-7082beabb403

copejon commented 5 years ago

+1

guymguym commented 5 years ago

I don't think there's a need to keep an open issue for that. Can we close @jeffvance ?

jeffvance commented 5 years ago

Yes it can be closed. Was just a suggestion for consideration.