search

kube-object-storage / lib-bucket-provisioner

Library for the dynamic provisioning of object store buckets to be used by object store providers.
Apache License 2.0
20 stars 22 forks source link

decide where -kubeconfig -master flags should live #81

Closed jeffvance closed 5 years ago

jeffvance commented 5 years ago

in the lib or in each provisioner?

copejon commented 5 years ago

~f they are pushed up to provisioners' scope, the library NewProvisioner should be made to accept the new k8s config rather than getting it itself. I'm in favor of this.~

Edit for clarity: It should not be the library's responsibility to get the config. This sets up situations for overloaded flag names that will generate compile time errors and require users to look through library code to be sure the duplication happens there. It's a safe bet that provisioner authors will get the config at a higher scope than the library, and so should pass this config to the provisioner constructor.

guymguym commented 5 years ago

Closing.