search

kube-rs / controller-rs

A kubernetes reference controller with actix-web
Apache License 2.0
282 stars 27 forks source link

Feat: add finalizer usage on the new crd #30

Closed yangsoon closed 2 years ago

yangsoon commented 2 years ago

Fix: https://github.com/kube-rs/controller-rs/issues/24

Hi, I just recently learned the rust language and really like your projects, thank you for reviewing

This PR add finalizer for the new CRD:

  1. when the CR Document been created, the controller will add a finalizer finalizer.document.io.
  2. when delete the CR, the controller will record an event with delete infromation , and remove the finalizer
clux commented 2 years ago

hey, thanks a lot for doing this. i like the finalizer cleanup behaviour with a dummy event. very nice.