kube-rs / controller-rs

A kubernetes reference controller
Apache License 2.0
270 stars 28 forks source link

build fails with just 1.13.0 #48

Closed mkmik closed 1 year ago

mkmik commented 1 year ago
$ uname -sm
Darwin arm64
$ just --version
just 1.13.0
$ just compile
error: Expected backtick, identifier, '(', ')', '/', or string, but found '{'
   |
47 | _build features="": (compile {{features}})
   |

I noticed the issue because I tried tilt up, which uses just

$ tilt up
Tilt started on http://localhost:10350/
v0.32.0, built 2023-03-13

(space) to open the browser
(s) to stream logs (--stream=true)
(t) to open legacy terminal mode (--legacy=true)
(ctrl-c) to exit
Tilt started on http://localhost:10350/
v0.32.0, built 2023-03-13

Initial Build
Loading Tiltfile at: /Users/mkm/Build/controller-rs/Tiltfile
compiling with features:
Successfully loaded Tiltfile (6.091125ms)
WARNING: You are running Kind without a local image registry.
Tilt can use the local registry to speed up builds.
Instructions: https://github.com/tilt-dev/kind-local
      compile │
      compile │ Initial Build
      compile │ Running cmd: just compile
      compile │ error: Expected backtick, identifier, '(', ')', '/', or string, but found '{'
      compile │    |
      compile │ 47 | _build features="": (compile {{features}})
      compile │    |                              ^
      compile │ ERROR: just compile exited with exit code 1
      compile │ ERROR: Build Failed: Command "just compile" failed: exit status
mkmik commented 1 year ago

Regression introduced in #47

clux commented 1 year ago

Ah, thanks. I must have missed some quotes in there. Did those last end bits rather quickly and the justfile isn't used in CI.