kube-rs / controller-rs

A kubernetes reference controller with actix-web
Apache License 2.0
282 stars 27 forks source link

Try out offficial `prometheus_client` for metrics #72

Closed clux closed 2 months ago

clux commented 4 months ago

A working POC for prometheus/client_rust ripping out tikv/rust-prometheus. Not much easier than measured (via #71) because the documentation is lackluster, but the codebase ends up being slightly nicer (and proc macro stuff less confusing for sure).

PROS:

CONS:

This is not updated well enough that I would be comfortable using it. If it had working protobuf and maybe native histograms or something this would be worth talking about, but it's only really bringing some slight ergonomics + exemplars to the table, that's useless if they don't update depedendencies. We don't have to choose this. There's no major downside for using an unofficial metrics crate if offical upstream is just a collection of unoptimized structs putting client in its name to make itself seem important.

clux commented 2 months ago

Exemplar showcase. grim-area-2024-09-07-11_48_56

Likely to merge this pr over the other for this feature.