search

kube-rs / kube

Rust Kubernetes client and controller runtime
https://kube.rs
Apache License 2.0
2.91k stars 304 forks source link

add missing feature gate on ConfigExt for no-features build #1549

Closed HoKim98 closed 2 months ago

HoKim98 commented 2 months ago

Motivation

Fixes #1548

Solution

In kube/src/lib.rs:L197,

Before

pub mod prelude {
    #[allow(unreachable_pub)] pub use crate::client::ConfigExt as _;
    ...
}

After

pub mod prelude {
    #[cfg(feature = "client")]
    #[allow(unreachable_pub)]
    pub use crate::client::ConfigExt as _;
    ...
}
HoKim98 commented 2 months ago

Re-committed to pass rust-fmt!

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.7%. Comparing base (5b3b73d) to head (29dfc10).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1549 +/- ## ===================================== Coverage 75.7% 75.7% ===================================== Files 79 79 Lines 7252 7252 ===================================== Hits 5487 5487 Misses 1765 1765 ``` | [Files](https://app.codecov.io/gh/kube-rs/kube/pull/1549?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kube-rs) | Coverage Δ | | |---|---|---| | [kube/src/lib.rs](https://app.codecov.io/gh/kube-rs/kube/pull/1549?src=pr&el=tree&filepath=kube%2Fsrc%2Flib.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kube-rs#diff-a3ViZS9zcmMvbGliLnJz) | `88.5% <ø> (ø)` | |
clux commented 2 months ago

I'll do a patch release with this shortly.

EDIT: released in 0.93.1