search

kube-rs / kube

Rust Kubernetes client and controller runtime
https://kube.rs
Apache License 2.0
3.03k stars 314 forks source link

Add finalizers predicate filter #1560

Closed ivan-kiselev closed 3 months ago

ivan-kiselev commented 3 months ago

As per relevant discussion

@clux I had to relax hash constraints with + ?Sized as .finalizers() returns &[String] of unknown on compile time size and so compiler wasn't exactly happy about that, but doesn't seem to be affecting anything else.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.4%. Comparing base (e2ceea8) to head (05bb5e9).

Files Patch % Lines
kube-runtime/src/utils/predicate.rs 33.4% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1560 +/- ## ======================================= - Coverage 75.4% 75.4% -0.0% ======================================= Files 80 80 Lines 7288 7290 +2 ======================================= Hits 5495 5495 - Misses 1793 1795 +2 ``` | [Files](https://app.codecov.io/gh/kube-rs/kube/pull/1560?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kube-rs) | Coverage Δ | | |---|---|---| | [kube-runtime/src/utils/predicate.rs](https://app.codecov.io/gh/kube-rs/kube/pull/1560?src=pr&el=tree&filepath=kube-runtime%2Fsrc%2Futils%2Fpredicate.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kube-rs#diff-a3ViZS1ydW50aW1lL3NyYy91dGlscy9wcmVkaWNhdGUucnM=) | `71.0% <33.4%> (-2.3%)` | :arrow_down: |