search

kube-rs / kube

Rust Kubernetes client and controller runtime
https://kube.rs
Apache License 2.0
3.03k stars 314 forks source link

remove using HTTP PROXY from environment variable #1587

Closed aviramha closed 1 month ago

aviramha commented 1 month ago

remove using HTTP PROXY from environment variable, matching kubectl's behavior.

I found out that kubectl doesn't care for the HTTP_PROXY environment variable, probably for security reasons (a way to have plaintext requests?)

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.3%. Comparing base (c0fe0c8) to head (08fda05). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1587 +/- ## ======================================= - Coverage 75.3% 75.3% -0.0% ======================================= Files 82 82 Lines 7331 7329 -2 ======================================= - Hits 5519 5517 -2 Misses 1812 1812 ``` | [Files with missing lines](https://app.codecov.io/gh/kube-rs/kube/pull/1587?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kube-rs) | Coverage Δ | | |---|---|---| | [kube-client/src/config/file\_loader.rs](https://app.codecov.io/gh/kube-rs/kube/pull/1587?src=pr&el=tree&filepath=kube-client%2Fsrc%2Fconfig%2Ffile_loader.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kube-rs#diff-a3ViZS1jbGllbnQvc3JjL2NvbmZpZy9maWxlX2xvYWRlci5ycw==) | `85.8% <ø> (-0.5%)` | :arrow_down: |
clux commented 1 month ago

This sounds sensible to me if the go side does not do it. CC @goenning who currently has a related issue under https://github.com/kube-rs/kube/issues/1203.

goenning commented 1 month ago

Ship it :)