search

kube-rs / kube

Rust Kubernetes client and controller runtime
https://kube.rs
Apache License 2.0
2.91k stars 304 forks source link

Upgrades Tower to 0.5.1 #1589

Closed markdingram closed 4 days ago

markdingram commented 5 days ago

fixes #1569

Motivation

Solution

hyper-util 0.1.9 unblocked this change by dropping the tower 0.4 dep -> https://github.com/hyperium/hyper-util/pull/151

tower 0.5 includes this change to make Buffer generic over the Future rather than the Service -> https://github.com/tower-rs/tower/pull/654

tower 0.5 includes this change to rework Either to no longer change the error type to BoxError, meaning Kube-RS now has to do so itself -> https://github.com/tower-rs/tower/pull/637

tower-http 0.6.1 includes this change which promises to improve (de)compression -> https://github.com/tower-rs/tower-http/pull/521

codecov[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 75.3%. Comparing base (acd2d8e) to head (6dd1938). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
kube-client/src/client/config_ext.rs 0.0% 3 Missing :warning:
kube-client/src/client/builder.rs 0.0% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1589 +/- ## ======================================= - Coverage 75.3% 75.3% -0.0% ======================================= Files 82 82 Lines 7327 7328 +1 ======================================= Hits 5515 5515 - Misses 1812 1813 +1 ``` | [Files with missing lines](https://app.codecov.io/gh/kube-rs/kube/pull/1589?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kube-rs) | Coverage Δ | | |---|---|---| | [kube-client/src/client/mod.rs](https://app.codecov.io/gh/kube-rs/kube/pull/1589?src=pr&el=tree&filepath=kube-client%2Fsrc%2Fclient%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kube-rs#diff-a3ViZS1jbGllbnQvc3JjL2NsaWVudC9tb2QucnM=) | `75.2% <ø> (ø)` | | | [kube-client/src/client/builder.rs](https://app.codecov.io/gh/kube-rs/kube/pull/1589?src=pr&el=tree&filepath=kube-client%2Fsrc%2Fclient%2Fbuilder.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kube-rs#diff-a3ViZS1jbGllbnQvc3JjL2NsaWVudC9idWlsZGVyLnJz) | `58.6% <0.0%> (-0.7%)` | :arrow_down: | | [kube-client/src/client/config\_ext.rs](https://app.codecov.io/gh/kube-rs/kube/pull/1589?src=pr&el=tree&filepath=kube-client%2Fsrc%2Fclient%2Fconfig_ext.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kube-rs#diff-a3ViZS1jbGllbnQvc3JjL2NsaWVudC9jb25maWdfZXh0LnJz) | `50.0% <0.0%> (ø)` | |