search

kube-vip / website

kube-vip website
Apache License 2.0
3 stars 21 forks source link

Incorrect env name `port` in DaemonSet example #28

Open lindhe opened 1 year ago

lindhe commented 1 year ago

According to the documentation, there is no variable named port. Do you mean lb_port here?

https://github.com/kube-vip/website/blob/12398baf5ae07e3143a1125f054f3cf42c19895e/content/docs/installation/daemonset.md?plain=1#L116-L117

https://github.com/kube-vip/website/blob/12398baf5ae07e3143a1125f054f3cf42c19895e/content/docs/installation/daemonset.md?plain=1#L222-L223

lindhe commented 1 year ago

Oh, maybe port is right and lb_port is wrong? I see that the generated pod spec uses port here:

https://github.com/kube-vip/kube-vip/blob/f7666067a49f04922c469198924b200dc8405084/pkg/kubevip/config_generator.go#L31-L34

lindhe commented 1 year ago

Looks like port is the right name: https://github.com/kube-vip/kube-vip/blob/f7666067a49f04922c469198924b200dc8405084/cmd/kube-vip.go#L77