search

kube / vscode-42header

42 header for VSCode
https://www.42.fr
MIT License
42 stars 41 forks source link

Extension causing editor suggestions to automatically scroll back to the top of the list #37

Closed Nazza01 closed 2 years ago

Nazza01 commented 2 years ago

Hey there! Thankyou for the extension it has assisted me greatly while studying!

Unfortunately I have ran into an inconvenient problem which seems to be happening whenever the timestamp is updated by the extension. Specifically when trying to use the editors' suggestions when typing out something (e.g. #include)

Issue - List scrolls automatically to the top whenever the file is updated

https://user-images.githubusercontent.com/9160772/166090032-e32f5c25-18e6-4a69-9dcf-641fac7995cf.mov

Intended action - no sudden jumps when using the arrow keys to navigate the editor suggestion list (had to remove 42 header to show issue).

https://user-images.githubusercontent.com/9160772/166089945-3d36b6a7-0225-401d-b74e-e2a5d7e41928.mov

I am unsure of how VSCode extensions are made so whether or not this can be addressed/fixed or a limitation of extensions themselves is another issue.

Nazza01 commented 2 years ago

I have found a workaround for this referenced here: https://github.com/Etheram68/Header101-Vscode/issues/10#issuecomment-749460747

but it seems more to be an internal problem with vscode when editing the file by the extension and the easiest way to solve the problem is to change the behavior of the autosave by changing the files.autoSave setting to onFocusChange

I have changed files.autoSave to onFocusChange and that has fixed the issue for the moment for anyone else having similar issues.

This will conflict with the norminette extension (https://github.com/Mariusmivw/vscode-42-norminette-3-highlighter) until I've either alt-tabbed or changed tabs/windows as that relies on the file being updated to show norm errors. But I am willing to put up with it for now.