Closed umbertix closed 9 months ago
hi @umbertix and thank you for your PR! I'm definitely interested in reviewing this one, and it seems everything is in place for it to be considered good, I only have a question, does it need any config tuning to be included as an init container like it happens for all the other components? (authentication, URL path to be configured or similar?)
Thank you!!
I haven't got time to look at it yet sorry, but I do imagine that will need some more work, this was just to open the dicsussion about the feature, since there is some interest I will try look into it a bit more.
I've tested the changes and this will succesfully spin up a working Jelly fin instance. The user will still will have to do a couple of manual steps but I think it's a good starting point.
Thank you so much for your contribution @umbertix! I will give it a run during the weekend, I wanted to ask you what manual steps are required, is it something that we can address with an init container as for other tools?
I was checking the manual steps, and what is the result for the config files. I haven't seen anything in the documentation that seems to point at a headless config option. And the XML config file looks rather ugly. Some of the steps are user/password setup and initial folders setup. I think is a nice addition but not super necessary to get things running. I'm still playing around with it to see if I can automate the user/password creation but it doesn't look too promissing as of right now.
Super, I think I will be able to run it today, if the initial config is something that is jellyfin related (like Plex that asks you to choose folders and similar or creating a user) I think we can keep it outside the definition.
Prowlarr has something similar introduced recently, but we usually take care of what's related to the deployment rather than the actual user experience (https/context/storage) leaving users freedom to customize the rest.
In the meantime we integrated some changes @InputObject2 worked on, it would be great if you can pull them into your branch, since many changes affect the tool definition in the CR, I will be happy to support injecting them in the Jellyfin bits as well.
Thank you for the contribution, looking forward to having it integrated soon 🚀
Just want to add a plus one to this PR.
I personally deployed Jellyfin from @umbertix's fork and it's working great for me!
As I promised yesterday, here I am :) Soooo! Everything is fine and really thanks again for your effort @umbertix!!! Before we proceed with the considerations we started with @reedjosh, I would really love to merge this one.
I just need to ask you to please make some slight modifications:
After this, I think we are good to go :)
Thank you @umbertix
@umbertix thank you SO MUCH! All is working smooth, I just added a not about the Jackett probe that must be tcpSocket due to how probes work and k8s limits on redirects (Jackett needs cookies to avoid redirects).
I made the modification and ran the integration tests that are now super green :D
Can I just ask you two last things?
I will just merge it afterwards, thank you!!
Unfortunelty I fucked up my local git and I think I deleted the branch fully when messing with the squash. I most likely lost the work there so, don't expect this to come up any time soon. Sorry :/
if you still have your local repo with the history you can still try to recover it using:
git checkout -b add-jellyfin-recovery 04f2789
04f2789 is the last commit you made (the typo thingy) and even if its history is unrelated, you can still recover everything! @umbertix
Lol @umbertix I was pointing to your branch with ArgoCD.
I woke up this morning to put a show on for the kiddos, but there was no longer a Jellyfin deployment in my k8s cluster. 🙃
Thanks for the tips, I got some time today to fix this mess (I think). And I've opened a new PR #98 , I hope this one is the final one Feel free to re-review it and test it to validate I haven't screwed any of the settings
Thx and sorry @reedjosh I hope ur kids weren't too mad at me ;)
This resolves: #44
I still need to run some more test, but would like to open the discussion and see if there is something else that you might want for this :)
Thanks for the hard work already done.