search

kubearmor / kubearmor-client

KubeArmor cli tool aka kArmor :robot:
Apache License 2.0
35 stars 84 forks source link

fix for downloading policy-templete zip #371

Closed Prateeknandle closed 1 year ago

Prateeknandle commented 1 year ago

removed grab package dependency for downloading policy-template zip file. grab.Get gives error server returned 403 Forbidden

using net/http package instead. for ref - https://accuknox.slack.com/archives/C0229TD83RA/p1694106383879899

Prateeknandle commented 1 year ago

@daemon1024 where should we store the zip?

daemon1024 commented 1 year ago

@Prateeknandle I meant that

https://github.com/kubearmor/kubearmor-client/blob/11d6d3e1c30b15faf8a6790747540579e195c9ad/recommend/recommend.go#L108

in this line, let's not return error but just log a Warning and continue recommend with old templates