kubebb / core

A declarative component lifecycle management platform
https://kubebb.github.io/website
Apache License 2.0
8 stars 9 forks source link

chore: add environment variable ENABLE_WEBHOOKS #227

Closed Abirdcfly closed 1 year ago

Abirdcfly commented 1 year ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it

  1. Environment variable has the highest priority
  2. options.CertDir can be configured through the config file, priority 2
  3. The default directory has a value of priority 3
  4. If the environment variable is configured, but there is a configuration error, exit directly.

    Which issue(s) this PR fixes

    Fixes #

Special notes for your reviewer

codecov[bot] commented 1 year ago

Codecov Report

Merging #227 (6b82547) into main (63fa908) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #227   +/-   ##
=======================================
  Coverage   13.38%   13.38%           
=======================================
  Files          32       32           
  Lines        3018     3018           
=======================================
  Hits          404      404           
  Misses       2600     2600           
  Partials       14       14           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Abirdcfly commented 1 year ago

test failed due to github rate-limiter

/home/runner/work/core/core/bin/controller-gen rbac:roleName=manager-role crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases
test -s /home/runner/work/core/core/bin/kustomize || { curl -s "https://raw.githubusercontent.com/kubernetes-sigs/kustomize/master/hack/install_kustomize.sh" | bash -s -- 3.8.7 /home/runner/work/core/core/bin; }
Github rate-limiter failed the request. Either authenticate or wait a couple of minutes.

https://github.com/kubebb/core/actions/runs/5792562549/job/15699054773?pr=227#step:6:92