search

kubebb / core

A declarative component lifecycle management platform
https://kubebb.github.io/website
Apache License 2.0
8 stars 9 forks source link

fix: componentplan webhook not check spec.componentRef #247

Closed Abirdcfly closed 1 year ago

Abirdcfly commented 1 year ago

What type of PR is this?

/kind bug

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes #

Special notes for your reviewer

codecov[bot] commented 1 year ago

Codecov Report

Merging #247 (c34ec81) into main (bb2eb94) will increase coverage by 0.27%. The diff coverage is 0.00%.

:exclamation: Current head c34ec81 differs from pull request most recent head bd675c4. Consider uploading reports for the commit bd675c4 to get more accurate results

@@            Coverage Diff             @@
##             main     #247      +/-   ##
==========================================
+ Coverage   17.87%   18.15%   +0.27%     
==========================================
  Files          33       33              
  Lines        3178     3118      -60     
==========================================
- Hits          568      566       -2     
+ Misses       2577     2519      -58     
  Partials       33       33
Files Changed Coverage Δ
api/v1alpha1/componentplan_webhook.go 6.38% <0.00%> (-1.52%) :arrow_down:
api/v1alpha1/webhook.go 0.00% <ø> (ø)

... and 3 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more