kubebb / core

A declarative component lifecycle management platform
https://kubebb.github.io/website
Apache License 2.0
8 stars 9 forks source link

refactor: helm action in componentplan controller #248

Closed Abirdcfly closed 1 year ago

Abirdcfly commented 1 year ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it

There are 5 commit:

Post-sequence tests will be added in the new pr.

Which issue(s) this PR fixes

For #194

Special notes for your reviewer

codecov[bot] commented 1 year ago

Codecov Report

Merging #248 (09b2056) into main (6c0f0f3) will decrease coverage by 0.02%. The diff coverage is 7.90%.

@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
- Coverage   17.61%   17.60%   -0.02%     
==========================================
  Files          34       35       +1     
  Lines        3452     3562     +110     
==========================================
+ Hits          608      627      +19     
- Misses       2811     2898      +87     
- Partials       33       37       +4     
Files Changed Coverage Δ
pkg/helm/helm_release_workpool.go 0.00% <0.00%> (ø)
controllers/componentplan_controller.go 6.17% <7.89%> (+6.17%) :arrow_up:
pkg/helm/helm.go 5.41% <68.00%> (+5.41%) :arrow_up:

... and 3 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Abirdcfly commented 1 year ago

test failed reported by #274, maybe fixed by #279