kubebb / core

A declarative component lifecycle management platform
https://kubebb.github.io/website
Apache License 2.0
8 stars 9 forks source link

refactor: simplify several helm func #254

Closed Abirdcfly closed 1 year ago

Abirdcfly commented 1 year ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes #

Special notes for your reviewer

codecov[bot] commented 1 year ago

Codecov Report

Merging #254 (2842967) into main (4910337) will increase coverage by 0.17%. The diff coverage is 0.00%.

:exclamation: Current head 2842967 differs from pull request most recent head 23db052. Consider uploading reports for the commit 23db052 to get more accurate results

@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
+ Coverage   17.77%   17.95%   +0.17%     
==========================================
  Files          33       33              
  Lines        3196     3164      -32     
==========================================
  Hits          568      568              
+ Misses       2595     2563      -32     
  Partials       33       33              
Files Changed Coverage Δ
controllers/componentplan_controller.go 0.00% <0.00%> (ø)
pkg/helm/helm.go 0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Abirdcfly commented 1 year ago

@Henry-Gao-2004 pls also review.

Henry-Gao-2004 commented 1 year ago

@Henry-Gao-2004 pls also review.

Nice changes! Thank you for simplifying the code!