search

kubebb / core

A declarative component lifecycle management platform
https://kubebb.github.io/website
Apache License 2.0
8 stars 9 forks source link

chore: remove unuse hack/tools/tools.go #276

Closed Abirdcfly closed 1 year ago

Abirdcfly commented 1 year ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it

why use tools package can see https://github.com/golang/go/wiki/Modules#how-can-i-track-tool-dependencies-for-a-module.

We use go install github.com/golangci/golangci-lint/cmd/golangci-lint to track tools version and we do not use code-generator directly.

Which issue(s) this PR fixes

Fixes #

Special notes for your reviewer

codecov[bot] commented 1 year ago

Codecov Report

Merging #276 (cf93764) into main (358f1d6) will not change coverage. Report is 1 commits behind head on main. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #276   +/-   ##
=======================================
  Coverage   16.96%   16.96%           
=======================================
  Files          34       34           
  Lines        3359     3359           
=======================================
  Hits          570      570           
  Misses       2756     2756           
  Partials       33       33

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Abirdcfly commented 1 year ago

test failed reported by #274, maybe fixed by #279