kubebb / core

A declarative component lifecycle management platform
https://kubebb.github.io/website
Apache License 2.0
8 stars 9 forks source link

refactor: portal conflict checks #279

Closed bjwswang closed 1 year ago

bjwswang commented 1 year ago

What type of PR is this?

/kind refactor

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes #273 Fixes #274

Special notes for your reviewer

  1. Update Portal status to have two fields to keep confilict status
    • conflictsInEntry
    • conflictsInPath
  2. fix the example test
codecov[bot] commented 1 year ago

Codecov Report

Merging #279 (358f1d6) into main (6fdd525) will increase coverage by 0.04%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #279      +/-   ##
==========================================
+ Coverage   16.92%   16.96%   +0.04%     
==========================================
  Files          34       34              
  Lines        3367     3359       -8     
==========================================
  Hits          570      570              
+ Misses       2764     2756       -8     
  Partials       33       33              
Files Changed Coverage Δ
api/v1alpha1/portal_types.go 100.00% <ø> (ø)
api/v1alpha1/zz_generated.deepcopy.go 0.00% <0.00%> (ø)
controllers/portal_controller.go 0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more