search

kubebb / core

A declarative component lifecycle management platform
https://kubebb.github.io/website
Apache License 2.0
8 stars 9 forks source link

fix: Long time installation continues even after uninstallation done #306

Closed Abirdcfly closed 1 year ago

Abirdcfly commented 1 year ago

What type of PR is this?

/kind bug

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes #

Special notes for your reviewer

codecov[bot] commented 1 year ago

Codecov Report

Merging #306 (0efe507) into main (a1e26aa) will decrease coverage by 0.06%. Report is 2 commits behind head on main. The diff coverage is 0.00%.

:exclamation: Current head 0efe507 differs from pull request most recent head 0cf51ca. Consider uploading reports for the commit 0cf51ca to get more accurate results

@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
- Coverage   25.92%   25.86%   -0.06%     
==========================================
  Files          35       35              
  Lines        3144     3151       +7     
==========================================
  Hits          815      815              
- Misses       2277     2284       +7     
  Partials       52       52
Files Changed Coverage Δ
pkg/helm/cmd.go 0.00% <0.00%> (ø)
pkg/helm/helm.go 6.85% <0.00%> (-0.12%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Abirdcfly commented 1 year ago

based on #303, need merge #303 first, change is only https://github.com/kubebb/core/pull/306/commits/0cf51ca94708b40de6e57afc8fb746bb9fb00145