kubebb / core

A declarative component lifecycle management platform
https://kubebb.github.io/website
Apache License 2.0
8 stars 9 forks source link

feat: add https authentication on repository #308

Closed zqq454224016 closed 1 year ago

zqq454224016 commented 1 year ago

What type of PR is this?

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes #288

Special notes for your reviewer

codecov[bot] commented 1 year ago

Codecov Report

Merging #308 (fe8c4cb) into main (5deb46f) will decrease coverage by 0.08%. The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main     #308      +/-   ##
==========================================
- Coverage   25.92%   25.84%   -0.08%     
==========================================
  Files          35       35              
  Lines        3144     3149       +5     
==========================================
- Hits          815      814       -1     
- Misses       2277     2283       +6     
  Partials       52       52              
Files Changed Coverage Δ
pkg/helm/helm.go 6.85% <0.00%> (-0.12%) :arrow_down:
pkg/helm/repo.go 58.27% <100.00%> (-0.28%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Abirdcfly commented 1 year ago

@0xff-dev @bjwswang @zqq454224016 any ideas about test? we can add it in next pr.

IMO, we can update basic-auth in example-test, just add cert with username and password. How we build certificates and the format of certificates can be used as a reference for front-end page display and tester testing.

bjwswang commented 1 year ago

LGTM. We can do it in next pr. @zqq454224016

Abirdcfly commented 1 year ago

test will be track by https://github.com/kubebb/core/issues/310