kubebb / core

A declarative component lifecycle management platform
https://kubebb.github.io/website
Apache License 2.0
8 stars 9 forks source link

feat: tracking rating status #363

Closed zqq454224016 closed 1 year ago

zqq454224016 commented 1 year ago

What type of PR is this?

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes #358

Special notes for your reviewer

codecov[bot] commented 1 year ago

Codecov Report

Merging #363 (3c8d014) into main (7cee163) will decrease coverage by 0.21%. The diff coverage is 0.00%.

:exclamation: Current head 3c8d014 differs from pull request most recent head ccf7ce0. Consider uploading reports for the commit ccf7ce0 to get more accurate results

@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
- Coverage   27.50%   27.30%   -0.21%     
==========================================
  Files          37       37              
  Lines        4475     4509      +34     
==========================================
  Hits         1231     1231              
- Misses       3141     3175      +34     
  Partials      103      103              
Files Coverage Δ
api/v1alpha1/condition.go 100.00% <ø> (ø)
controllers/rating_controller.go 0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

bjwswang commented 1 year ago

@0xff-dev pls confirim this change can fix #368

zqq454224016 commented 1 year ago

@0xff-dev @Abirdcfly pls review this pr.