search

kubecost / cluster-turndown

Automated turndown of Kubernetes clusters on specific schedules.
Apache License 2.0
259 stars 23 forks source link

Update command to start cluster-turdown pod #41

Closed billmetangmo closed 2 years ago

billmetangmo commented 2 years ago

kubectl apply -f https://github.com/kubecost/cluster-turndown/releases/latest/download/cluster-turndown-full.yaml failed with error error: unable to read URL "https://github.com/kubecost/cluster-turndown/releases/latest/download/cluster-turndown-full.yaml", server reported 404 Not Found, status code=404 .

So I suggest to add local path as above in the documentation, the repo should be cloned.

Adam-Stack-PM commented 2 years ago

@dwbrown2 Could I get your eyes on this, and should it go into v1.94?

dwbrown2 commented 2 years ago

I'll defer to @michaelmdresser or @mbolt35 . Definitely seems like we should fix 404 in some capacity.

michaelmdresser commented 2 years ago

Hi @billmetangmo, thanks for this report and PR.

Rather than providing relative paths (forcing users to clone this repo), we do want to be using a URL based on the release. We hadn't uploaded the full set of necessary files to the latest release of cluster-turndown, so you encountered this error.

I've uploaded the correct files, so you should no longer encounter this error, and I've added relevant steps to the release process in https://github.com/kubecost/cluster-turndown/pull/43 to avoid this issue in the future.

I'm going to close this PR, but feel free to continue discussion, reopen, or open a new issue/PR if you continue to have problems!

michaelmdresser commented 2 years ago

@AdamStack18 this problem is fortunately not tied to the standard Kubecost release process, so no need to track it for a 1.9X release!