search

kubecost / cost-analyzer-helm-chart

Kubecost helm chart
http://kubecost.com/install
Apache License 2.0
488 stars 418 forks source link

allow custom minimum cpu and memory params for rightsizing v2 #1974

Closed jessegoodier closed 1 year ago

jessegoodier commented 1 year ago

What problem are you trying to solve? Customer requesting ability to set minimum cpu and memory recommendation using request sizing v2 api.

Describe the solution you'd like Still TBD if customer wants this in UI. But they are using API for sure. Can see potential for helm values, but also TBD.

Describe alternatives you've considered NA

How would users interact with this feature? API args.

┆Issue is synchronized with this Jira Task by Unito

AjayTripathy commented 1 year ago

From thread offline:

these are currently hardcoded: https://github.com/kubecost/kubecost-cost-model/blob/2f37b267640d104580d443ecb9c2bdfcba326056/pkg/savings/requestsizing/v2/handlers.go#L103-L104
but could absolutely be turned into API params
michaelmdresser commented 1 year ago

PR linked to close this request.

jessegoodier commented 1 year ago

Customer confirmed that API is all they are asking for, though I can see a lot of benefit to UI config as well.

michaelmdresser commented 1 year ago

cc @nealormsbee adding a UI field for this is easy, but low priority right now. Could be a good onboarding task if you have anyone new coming on board soon.