additional aggregator tuning

jessegoodier commented 3 months ago

What does this PR change?

Adding key pairs for more common tuning parameters. Added helm failure to prevent unknowingly removing required variables.

Message to users with .Values.kubecostAggregator.env` settings:

Error: UPGRADE FAILED: execution error at (cost-analyzer/templates/NOTES.txt:3:4): Upgrade issue:
Kubecost 2.3 has updated the aggregator's environment variables. 
Please update your values.yaml to use the new key pairs. See:
https://docs.kubecost.com/install-and-configure/install/multi-cluster/federated-etl/aggregator#aggregator-optimizations 
for additional information. 
In Kubecost 2.3, kubecostAggregator.env is no longer used in favor of the new key pairs.
This was done to prevent unexpected behavior and to simplify the aggregator's configuration.

Does this PR rely on any other PRs?

No

How does this PR impact users? (This is the kind of thing that goes in release notes!)

Adding key pairs for more common tuning parameters. Any user with .Values.kubecostAggregator.env configurations must update the configuration to use these key pairs.

Links to Issues or tickets this PR addresses or fixes

NA

What risks are associated with merging this PR? What is required to fully test this PR?

Fixes an issue discovered internally by @thomasvn

How was this PR tested?

Helm templating and against QA environments to ensure no duplicate values are created.

Have you made an update to documentation? If so, please provide the corresponding PR.

https://github.com/kubecost/docs/pull/1074

jessegoodier commented 3 months ago

@thomasvn please merge when ready.

thomasvn commented 3 months ago

FYI @mclean0328 @srpomeroy @williamkubecost

jessegoodier commented 3 months ago

/cherry-pick v2.3

kubecost / cost-analyzer-helm-chart