search

kubecost / cost-analyzer-helm-chart

Kubecost helm chart
http://kubecost.com/install
Apache License 2.0
478 stars 416 forks source link

no dupe labels #3500

Closed jessegoodier closed 3 months ago

jessegoodier commented 3 months ago

What does this PR change?

Remove duplicate labels from cost-analyzer and frontend deployments

Does this PR rely on any other PRs?

No

How does this PR impact users? (This is the kind of thing that goes in release notes!)

Removed duplicate labels from cost-analyzer and frontend pods

Links to Issues or tickets this PR addresses or fixes

Resolve issue reported by FluxCD helm-controller via slack

What risks are associated with merging this PR? What is required to fully test this PR?

NA

How was this PR tested?

Manually verified the labels are not duplicated and that Kubecost is still healthy

Have you made an update to documentation? If so, please provide the corresponding PR.

NA

jessegoodier commented 3 months ago

/cherry-pick v2.3

chipzoller commented 3 months ago

Have you tried an upgrade from 2.3.0 to this version? Since this is a removal, I don't know if there will be an error being that these impact Pod selection.

thomasvn commented 3 months ago

I think (?) this should be a safe change? I don't know if removal of these labels has any unintended effects. @srpomeroy @mclean0328 @williamkubecost for awareness.

jessegoodier commented 3 months ago

Have you tried an upgrade from 2.3.0 to this version? Since this is a removal, I don't know if there will be an error being that these impact Pod selection.

tested just now, no issue.

jessegoodier commented 3 months ago

/cherry-pick v2.3