kubecost / cost-analyzer-helm-chart

Kubecost helm chart
http://kubecost.com/install
Apache License 2.0
458 stars 410 forks source link

[Feature] Add nodeSelector for mimir-proxy-deployment #3519

Open nantiferov opened 1 week ago

nantiferov commented 1 week ago

Problem Statement

mimir-proxy was added in https://github.com/kubecost/cost-analyzer-helm-chart/pull/2201 and from my understanding, now it's impossible to set nodeSelector via Helm values, since it's missing in template https://github.com/kubecost/cost-analyzer-helm-chart/blob/develop/cost-analyzer/templates/mimir-proxy-deployment-template.yaml

Solution Description

Add ability to define optional nodeSelector, which will be used in mimir-proxy-deployment-template.yaml template. Not sure, but probably it could be set in spec.values.global.mimirProxy or create a new section for it.

Btw, it's also impossible to define resources requests/limits for mimir-proxy, which would be useful to add as well I think. Since now they're not set.

Alternatives

No response

Additional Context

I can prepare PR for this feature if solution sounds good.

Troubleshooting