Closed chipzoller closed 5 months ago
~Not to self: once merged and the first release cut, need to update manifest to use latest tag. Also, try fail on vuln types if detected.~ I went ahead and update the image in the install.yaml
manifest to go ahead and point to the new repo and latest
tag. We'll just want to build as soon as this gets merged so the image ref is valid.
@avrodrigues5, can we add ldflags s and w to further reduce build size? Just may be impacted if needing to run a debugger. Any concerns there?
Let me know what other questions you have about this releaser workflow. I realize that ko
is probably new to you so glad to address any concerns.
@chipzoller high level this looks good.
Few questions:
SBOM and vuln scans are attached as attestations to the image in the registry and also available as release assets.
Use of those flags drops the size by about 50%, and since we probably don't need a tice debugging at this point my suggestion would be to add them until we see a case where this presents a problem.
@avrodrigues5, I added the .ko.yaml
with the ldflags set.
Signed-off-by: Chip Zoller chipzoller@gmail.com
What does this PR change?
install.yaml
with the digest from the release process.install.yaml
manifest as well as updates theimage
string to use thelatest
tag which will become available after the first and any subsequent release actions.ko
Does this PR rely on any other PRs?
No
How does this PR impact users?
CI only but allows users to verify modern software supply chain security for this project.
Links to Issues or tickets this PR addresses or fixes
Closes #7
What risks are associated with merging this PR? What is required to fully test this PR?
The first release build needs to be triggered after this is accepted so the new image and its assets are pushed into the correct repository.
How was this PR tested?
In a separate repo.