kubecost / docs

GitHub repository for the official Kubecost documentation.
http://docs.kubecost.com
90 stars 104 forks source link

Is Node exporter optional? #426

Closed jcharcalla closed 1 year ago

jcharcalla commented 1 year ago

Our docs say node-exporter is optional. We should test this and document what impacts if any result from disabling it (ie: less functionality).

dwbrown2 commented 1 year ago

This should be documented somewhere but probably worth testing on latest. @AjayTripathy do you know where?

jcharcalla commented 1 year ago

I'll look through the docs again to see if I can find any already.

jcharcalla commented 1 year ago

So there is this...

https://guide.kubecost.com/hc/en-us/articles/6446286863383-Tuning-Resource-Consumption#disable-or-stop-scraping-node-exporter "Node-exporter is optional. Some health alerts will be disabled if node-exporter is disabled, but savings recommendations and core cost allocation will function as normal"

And then on this page: https://guide.kubecost.com/hc/en-us/articles/4423256582551-Kubecost-Secondary-Clusters#node-exporter "You can disable node-exporter and the service account if cluster/node rightsizing recommendations are not required."

To me those descriptions almost conflict "but savings recommendations ... will function as normal" vs "if cluster/node rightsizing recommendations are not required".

I think there is room to improve here by clarifying what features will be unavailable when node-exporter is disabled.

brstuder commented 1 year ago

If we have a list of the key features that aren't accessible when the node exporter is disabled, I can start adding this to the docs.

brstuder commented 1 year ago

I would say it should be added to the Tuning Resource Consumption page, where we already have a section dedicated to the subject