[Bug] Cluster Controller stopped targeting namespace level annotations

passionInfinite commented 4 months ago

Kubecost Version

2.3.2

Kubernetes Version

v1.27.7

Kubernetes Platform

AKS

Description

We did a POC before and at that time the cluster controller was able to target the workloads defined under a namespace by adding container request right sizing annotations to the namespaces.

Recently it has stopped working at the namespace level. We are expecting it to support annotations at namespace level and if it can only target Deployments that's fine but definition needs to be at namespace level.

Steps to reproduce

Enable cluster controller.
Add annotations to any namespace level where you have recommendation for deployment controller kind.
Cluster controller will never apply those recommendations to those deployments.

Expected behavior

It should atleast apply to the deployments under the specified namespaces.

Impact

This is breaking for us as we completed POC at that time it was working with Annotations at the Namespace Level but now its inverse where we don't see cluster controller applying the recommendations.

Screenshots

No response

Logs

│ 2024-07-09T14:21:22Z INF Determined to be running in a cluster. Using in-cluster K8s config.                                                                                                │
│ 2024-07-09T14:21:25Z INF Successfully initialized Continuous Request Sizing                                                                                                                 │
│ 2024-07-09T14:21:25Z INF Kubescaler run started                                                                                                                                             │
│ 2024-07-09T14:21:25Z INF Starting main loop                                                                                                                                                 │
│ 2024-07-09T14:21:25Z INF Found ProviderID starting with "azure", using Azure Provider                                                                                                       │
│ 2024-07-09T14:21:25Z WRN Cluster Controller is only configured to modify resources on this cluster. To enable Cloud Provider Account scoped actions (like cluster turndown), please configu │
│ 2024-07-09T14:21:28Z INF Successfully initialized Namespace Turndown

Just being idle.

Slack discussion

No response

Troubleshooting

[X] I have read and followed the issue guidelines and this is a bug impacting only the Kubecost application.
[X] I have searched other issues in this repository and mine is not recorded.

chipzoller commented 3 months ago

This is curious. "Officially" this never worked by annotating a Namespace directly and a bit of internal discussion resulted revealed we didn't remove any code to block this. On what version of Kubecost did you discover annotating a Namespace resulted in CC resizing all the Deployments?

chipzoller commented 3 weeks ago

Hello, in an effort to consolidate our bug and feature request tracking, we are deprecating using GitHub to track tickets. If this issue is still outstanding and you have not done so already, please raise a request at https://support.kubecost.com/.

kubecost / features-bugs