search

kubecost / features-bugs

A public repository for filing of Kubecost feature requests and bugs. Please read the issue guidelines before filing an issue here.
0 stars 0 forks source link

Error while using "includeLabelsAndAnnotations" in https://docs.kubecost.com/apis/savings-apis/api-request-right-sizing-v2 #71

Closed sharanm closed 3 weeks ago

sharanm commented 7 months ago

Kubecost Helm Chart Version

2.2.1

Kubernetes Version

1.27

Kubernetes Platform

Other (specify in description)

Description

KUBECOST_ADDRESS='http://localhost:9090/model'

curl -G \ -d 'algorithmCPU=max' \ -d 'algorithmRAM=max' \ -d 'targetCPUUtilization=1' \ -d 'targetRAMUtilization=1' \ -d 'window=36h' \ -d 'includeLabelsAndAnnotations=true' \ --data-urlencode 'filter=namespace:"default"' \ ${KUBECOST_ADDRESS}/savings/requestSizingV2

..

Failed to parse request into request sizing options: invalid HTTP parameters present: [includeLabelsAndAnnotations]

If above argument is removed things work as expected

Steps to reproduce

  1. Install kubecost via Helm
  2. Perform port-forward
  3. Execute API

Expected behavior

We should be able to see recommendation along with annoations and labels but instead get error as reported above

Impact

No response

Screenshots

No response

Logs

No response

Slack discussion

No response

Troubleshooting

jessegoodier commented 7 months ago

Thanks for reporting this. Looks like it is a bug introduced with 2.0. Will get it added to the priorities.

sharanm commented 7 months ago

Is there a way to workaround this for now? Would version downgrade work? If yes, which version should I use?

On Fri, Apr 12, 2024, 10:23 PM Jesse Goodier @.***> wrote:

Thanks for reporting this. Looks like it is a bug introduced with 2.0. Will get it added to the priorities.

— Reply to this email directly, view it on GitHub https://github.com/kubecost/features-bugs/issues/71, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAONDMM6373PRPUARVSWPRDY5AGPJAVCNFSM6AAAAABGCBUCF6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJSGEZDCMJYGM . You are receiving this because you authored the thread.Message ID: @.***>

jessegoodier commented 7 months ago

yes downgrading to version 1.108.1 without using aggregator (which is not enabled by default) works.

sharanm commented 6 months ago

Oh , that would be quite a downgrade, any rough estimate by what time this can eb fixed ?

jessegoodier commented 6 months ago

Sorry for that. Agree 2.x is much nicer. :)

Almost certainly in 2.3, which is about a month.

chipzoller commented 6 months ago

Does not appear to be an issue with the Helm chart. Transferred to the correct repository.

chipzoller commented 3 weeks ago

Hello, in an effort to consolidate our bug and feature request tracking, we are deprecating using GitHub to track tickets. If this issue is still outstanding and you have not done so already, please raise a request at https://support.kubecost.com/.