Nick/split cost usage window - Githubissues

kubecost / kubectl-cost

CLI for determining the cost of Kubernetes workloads

Apache License 2.0

872 stars 55 forks source link

Nick/split cost usage window #145

Closed nickcurie closed 1 year ago

nickcurie commented 1 year ago

What does this PR change?

Splits window flag into two separate flags. One for determining historical usage, and another for determining costs.
- This allows users to use reconciled cost data by passing a 48hr offset window.

Does this PR rely on any other PRs?

https://github.com/kubecost/kubecost-cost-model/pull/1290

How does this PR impact users? (This is the kind of thing that goes in release notes!)

Added separate usage and cost window flags

Links to Issues or ZD tickets this PR addresses or fixes

https://github.com/kubecost/kubecost-cost-model/issues/1250

How was this PR tested?

Observed flags sending correct windows for both usage and cost

Have you made an update to documentation?

No

michaelmdresser commented 1 year ago

NOTE: This cannot be released until v1.102 of Kubecost. Perhaps we should make a compatibility note in the README as part of this PR. I'll give it some thought.