Closed Yoda-wu closed 3 weeks ago
There are three CI issues that remain to be resolved, mainly for Pylint, see https://github.com/kubeedge/ianvs/actions/runs/11268242806
Thanks for comment!, but i think the linked action is not my pr's action. I have some question about Pylint, In Pylint(3.9) it got error:
Run pylint '/home/runner/work/ianvs/ianvs/core'
************* Module core.testenvmanager.dataset.dataset
core/testenvmanager/dataset/dataset.py:124:4: R091[7](https://github.com/kubeedge/ianvs/actions/runs/11320404587/job/31477907116#step:5:8): Too many positional arguments (8/5) (too-many-positional-arguments)
core/testenvmanager/dataset/dataset.py:237:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments)
core/testenvmanager/dataset/dataset.py:244:4: R0[9](https://github.com/kubeedge/ianvs/actions/runs/11320404587/job/31477907116#step:5:10)17: Too many positional arguments (7/5) (too-many-positional-arguments)
core/testenvmanager/dataset/dataset.py:291:4: R0917: Too many positional arguments (7/5) (too-many-positional-arguments)
core/testenvmanager/dataset/dataset.py:349:4: R0917: Too many positional arguments (7/5) (too-many-positional-arguments)
core/testenvmanager/dataset/dataset.py:422:4: R0917: Too many positional arguments (7/5) (too-many-positional-arguments)
core/testenvmanager/dataset/dataset.py:492:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments)
************* Module core.testcasecontroller.algorithm.paradigm.singletask_learning.singletask_learning_active_boost
core/testcasecontroller/algorithm/paradigm/singletask_learning/singletask_learning_active_boost.py:66:4: R0917: Too many positional arguments (7/5) (too-many-positional-arguments)
which is not my pr's feature. I try to add disabel too-many-positional-arguments and it turn outs that Pylint(3.7,3.8) can't recognize this argument.
Run pylint '/home/runner/work/ianvs/ianvs/core'
************* Module core.testenvmanager.dataset.dataset
core/testenvmanager/dataset/dataset.py:119:0: W0012: Unknown option value for 'disable', expected a valid pylint message and got 'too-many-positional-arguments' (unknown-option-value)
core/testenvmanager/dataset/dataset.py:20[7](https://github.com/kubeedge/ianvs/actions/runs/11137579503/job/31477583235?pr=143#step:5:8):0: W0012: Unknown option value for 'disable', expected a valid pylint message and got 'too-many-positional-arguments' (unknown-option-value)
core/testenvmanager/dataset/dataset.py:215:0: W0012: Unknown option value for 'disable', expected a valid pylint message and got 'too-many-positional-arguments' (unknown-option-value)
core/testenvmanager/dataset/dataset.py:249:0: W0012: Unknown option value for 'disable', expected a valid pylint message and got 'too-many-positional-arguments' (unknown-option-value)
core/testenvmanager/dataset/dataset.py:2[8](https://github.com/kubeedge/ianvs/actions/runs/11137579503/job/31477583235?pr=143#step:5:9)8:0: W0012: Unknown option value for 'disable', expected a valid pylint message and got 'too-many-positional-arguments' (unknown-option-value)
core/testenvmanager/dataset/dataset.py:334:0: W0012: Unknown option value for 'disable', expected a valid pylint message and got 'too-many-positional-arguments' (unknown-option-value)
@chenhaorui0768: changing LGTM is restricted to collaborators
/lgtm
@hsj576 might also want to have a look at this project
The EGG-INFO file should not be uploaded to the github repository.
Sorry about that, i remove it right now
/lgtm
@chenhaorui0768: changing LGTM is restricted to collaborators
This pull request contains 8 commits, which might make maintenance difficult, considering the number of contributors, pull requests, and their commits in KubeEdge Ianvs recently. In the final stage, @Yoda-wu can squash the commits into one using rebase techniques.
thank you for the advice! i will squash the commits if this pr have nothing to change. Looking forward to more reviews from @MooreZheng @chenhaorui0768 @hsj576. Due to the deadline of OSPP, please feel free to comment so i can fix it asap~
/lgtm
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: MooreZheng
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR add two main feature:
Besides this PR also add the example of these two paradigm.
Which issue(s) this PR fixes: related issue: https://github.com/kubeedge/ianvs/issues/97
Fixes #