search

kubeedge / ianvs

Distributed Synergy AI Benchmarking
https://ianvs.readthedocs.io
Apache License 2.0
115 stars 46 forks source link

add Impl for llm edge benchmark suite #150

Closed XueSongTap closed 3 weeks ago

XueSongTap commented 1 month ago

What type of PR is this?

/kind feature

What this PR does / why we need it:

add Impl for llm edge benchmark suite

Which issue(s) this PR fixes:

https://github.com/kubeedge/ianvs/pull/127

XueSongTap commented 3 weeks ago

@hsj576 Could you please review this PR? I've made several documentation and configuration updates:

Here's screenshot of the benchmark ：

image image

The results show the changes are working as expected,

Let me know if you need any additional information or clarification.

XueSongTap commented 3 weeks ago

@MooreZheng I have already addressed this concern by squashing all commits into a single commit using rebase. The changes are now consolidated into one cohesive commit for better maintenance and clearer history. Please review the updated changes.

MooreZheng commented 3 weeks ago

/lgtm

MooreZheng commented 3 weeks ago

@XueSongTap might need one more review from @hsj576

hsj576 commented 3 weeks ago

/lgtm

CreativityH commented 3 weeks ago

/lgtm

kubeedge-bot commented 3 weeks ago

@CreativityH: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubeedge/ianvs/pull/150#issuecomment-2445706228): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
XueSongTap commented 3 weeks ago

@MooreZheng hi, i've changed print() using logger. Could you please review this PR? Let me know if you need any additional information or clarification.

MooreZheng commented 3 weeks ago

/lgtm

MooreZheng commented 3 weeks ago

/approve

kubeedge-bot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MooreZheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeedge/ianvs/blob/main/OWNERS)~~ [MooreZheng] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment