search

kubeedge / kubeedge

Kubernetes Native Edge Computing Framework (project under CNCF)
https://kubeedge.io
Apache License 2.0
6.52k stars 1.68k forks source link

Change edge join to use systemd in pure go #5618

Open forsaken628 opened 1 month ago

forsaken628 commented 1 month ago

What type of PR is this? /kind cleanup

What this PR does / why we need it: This implements the join command using pure go instead of commands. It also adds a 5 minute timeout for starting the service.

Which issue(s) this PR fixes:

Fixes #3860

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
kubeedge-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign kadisi after the PR has been reviewed. You can assign the PR to them by writing /assign @kadisi in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeedge/kubeedge/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kubeedge-bot commented 1 month ago

Welcome @forsaken628! It looks like this is your first PR to kubeedge/kubeedge 🎉