search

kubeedge / kubeedge

Kubernetes Native Edge Computing Framework (project under CNCF)
https://kubeedge.io
Apache License 2.0
6.53k stars 1.68k forks source link

update go 1.21 for kubeedge build image #5652

Closed Shelley-BaoYue closed 3 weeks ago

Shelley-BaoYue commented 3 weeks ago

What type of PR is this?

/kind feature

What this PR does / why we need it:

update go 1.21 for kubeedge build tool image, keep consistent with Kubernetes

WillardHu commented 3 weeks ago

Does the version of golang also need to be upgraded in the go.mod?

Shelley-BaoYue commented 3 weeks ago

Does the version of golang also need to be upgraded in the go.mod?

Yes, it will be put at a seperate PR. We need to upgrate the go version in KubeEdge basic image, and then upgrate it in other parts. Ref to: https://github.com/kubeedge/kubeedge/pull/5123 and https://github.com/kubeedge/kubeedge/pull/5146

WillardHu commented 3 weeks ago

/lgtm

Shelley-BaoYue commented 3 weeks ago

PTAL @fisherxu @wbc6080

kubeedge-bot commented 3 weeks ago

@wbc6080: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/kubeedge/kubeedge/pull/5652#pullrequestreview-2100983289): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kubeedge-bot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fisherxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeedge/kubeedge/blob/master/OWNERS)~~ [fisherxu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment