search

kubeedge / mappers-go

KubeEdge Device Mappers written in go
Apache License 2.0
45 stars 64 forks source link

add usbcamera-dmi #122

Closed luomengY closed 7 months ago

luomengY commented 9 months ago

A USB protocol camera mapper developed based on the dmi and mapper framework. @cl2017 @wbc6080

wbc6080 commented 9 months ago

Is the vendor folder necessary? Can we use go.mod directly? Otherwise, there will be too many files and review will be difficult

luomengY commented 9 months ago

Is the vendor folder necessary? Can we use go.mod directly? Otherwise, there will be too many files and review will be difficult

ok, I have deleted the vendor.

wbc6080 commented 7 months ago

Would it be better to change the directory name to mappers/kubeedge-v1.15.0/usbcamera-dmi/... ?

luomengY commented 7 months ago

kubeedge-v1.15.0

ok

wbc6080 commented 7 months ago

/lgtm

kubeedge-bot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fisherxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeedge/mappers-go/blob/main/OWNERS)~~ [fisherxu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment