search

kubeedge / mappers-go

KubeEdge Device Mappers written in go
Apache License 2.0
48 stars 67 forks source link

Extract function validate device instance #29

Closed gy95 closed 3 years ago

gy95 commented 3 years ago

Extract the common function ValidateProfileDeviceInstance to validate device instance in parsing the configmap for three different protocols: bluetooth, opcua, modbus

Signed-off-by: gy95 guoyao17@huawei.com

kubeedge-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign kevin-wangzefeng after the PR has been reviewed. You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeedge/mappers-go/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kubeedge-bot commented 3 years ago

@gy95: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.