kubeedge / mappers-go

KubeEdge Device Mappers written in go
Apache License 2.0
46 stars 65 forks source link

Add onvif mapper #48

Closed sailorvii closed 3 years ago

sailorvii commented 3 years ago
  1. Add onvif mapper.
  2. Refine compile dependency.
  3. Refine some minor code issues.
  4. Add customized mapper guide.
kubeedge-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign sailorvii after the PR has been reviewed. You can assign the PR to them by writing /assign @sailorvii in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeedge/mappers-go/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sailorvii commented 3 years ago

@fisherxu Could we split another tree for ONVIF? Because the build needs lots of dependencies which wastes time to other check-ins. Or is there another solution?

fisherxu commented 3 years ago

Don't forget to signoff the commit :)

kubeedge-bot commented 3 years ago

@sailorvii: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
fisherxu commented 3 years ago

Conflicted?