search

kubeedge / mappers-go

KubeEdge Device Mappers written in go
Apache License 2.0
46 stars 65 forks source link

Add Mapper SDK #70

Closed QiQi-OvO closed 2 years ago

QiQi-OvO commented 2 years ago

What type of PR is this? /kind feature

What this PR does / why we need it: mapper SDK helps developers reduce the workload of developing mapper.

Which issue(s) this PR fixes: Fixes https://github.com/kubeedge/mappers-go/issues/69

Special notes for your reviewer:

  1. You can find more details in docs.
  2. You can find a demo named virtualdevice-sdk in mappers/virtualdevice-sdk
kubeedge-bot commented 2 years ago

Welcome @QiQi-OvO! It looks like this is your first PR to kubeedge/mappers-go 🎉

RyanZhaoXB commented 2 years ago

hello, Qi @QiQi-OvO . your commit should be provided with sign-off information. you can try to re-commit with this command git commit -s -m "XXX" or git commit -s --amend and push your commit again.

kubeedge-bot commented 2 years ago

@RyanZhaoXB: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/kubeedge/mappers-go/pull/70#issuecomment-1118214540): >/test all Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kubeedge-bot commented 2 years ago

@RyanZhaoXB: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubeedge/mappers-go/pull/70#pullrequestreview-962984709): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kubeedge-bot commented 2 years ago

@RyanZhaoXB: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubeedge/mappers-go/pull/70#pullrequestreview-965718698): >lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
RyanZhaoXB commented 2 years ago

@fisherxu please help to review this pr. thanks.

RyanZhaoXB commented 2 years ago

@chendave @fisherxu please help to review this pr. thanks.

kubeedge-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fisherxu, RyanZhaoXB

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeedge/mappers-go/blob/main/OWNERS)~~ [fisherxu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment