search

kubeedge / mappers-go

KubeEdge Device Mappers written in go
Apache License 2.0
45 stars 64 forks source link

add implement dmi interface #78

Closed cl2017 closed 1 year ago

cl2017 commented 1 year ago

What type of PR is this? /kind feature

What this PR does / why we need it: add implement dmi interface

Which issue(s) this PR fixes: NONE

Special notes for your reviewer:

kubeedge-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign chendave after the PR has been reviewed. You can assign the PR to them by writing /assign @chendave in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeedge/mappers-go/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
wackxu commented 1 year ago

I see that we update the code in the original logic code, shall we create new dir and files to keep the old mapper until the dmi is in production. cc @RyanZhaoXB

fisherxu commented 1 year ago

@cl2017 Please fix the failed ci tests, thanks.