search

kubeedge / mappers-go

KubeEdge Device Mappers written in go
Apache License 2.0
45 stars 64 forks source link

[bugfix]fix some bug of DMI mapper of modbus #96

Open RyanZhaoXB opened 1 year ago

RyanZhaoXB commented 1 year ago

fix some bug of DMI mapper of modbus:

  1. fix bug for nil pointer of twin and context thread block
  2. do not report if the twin data is not changed to prevent triggering traffic limiting
  3. update log level and support twin for string, bool and float type
kubeedge-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign fisherxu after the PR has been reviewed. You can assign the PR to them by writing /assign @fisherxu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeedge/mappers-go/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kubeedge-bot commented 2 months ago

@RyanZhaoXB: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.