Docs: Improving the install with binary docs

kubeedge / website

KubeEdge website and documentation repo:

https://kubeedge.io

Apache License 2.0

52 stars 154 forks source link

Docs: Improving the install with binary docs #558

Open 1Shubham7 opened 4 months ago

1Shubham7 commented 4 months ago

Please check if the PR fulfills these requirements
[x] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) docs update
What is the new behavior (if this is a feature change)?

this is one among series of PRs planned to improve and rewrite some parts of documentation. Here I improved the "install with binary" docs.

Works towards solving #533

1Shubham7 commented 4 months ago

@wbc6080 @fujitatomoya I am looking for your suggestions here as well.

1Shubham7 commented 3 months ago

the fix lgtm with a couple of minor nitpics.

btw, why do we need to maintain? this is not even recommended procedure to install KubeEdge, what is the use case for this procedure? even with testing environment, we should not set up the KubeEdge with binaries? if that is so, probably we can just remove this page? i may be missing some cases, not sure about the history...

@wbc6080 @fisherxu what are your views?

1Shubham7 commented 3 months ago

added all your suggestions, Please also confirm that we are only using beta version of device crd and other crds need not be updated.

fujitatomoya commented 3 months ago

This part is mainly for developers. After modifying some codes of kubeedge, you can directly start the kubeedge cluster in binary mode for testing. I think it is necessary to keep this part, otherwise developers will not be able to check whether the subsequent kubeedge can work normally after the modifications.

@wbc6080 thanks for clarification.

1Shubham7 commented 3 months ago

@fujitatomoya @wbc6080 please approve this PR :)

kubeedge-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fujitatomoya, wbc6080 To complete the pull request process, please assign shelley-baoyue after the PR has been reviewed. You can assign the PR to them by writing /assign @shelley-baoyue in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeedge/website/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kubeedge-bot commented 3 weeks ago

New changes are detected. LGTM label has been removed.