feat(terraform): various terraform tweaks

kubefirst / gitops-template

a template of gitops infrastucture for consumption by kubefirst users

MIT License

55 stars 51 forks source link

Closed FalcoSuessgott closed 3 months ago

FalcoSuessgott commented 4 months ago

avoided depends_on in all vault modules
run terraform format for all terraform dirs.
added a Makefile with fmt and validate target to perform these options conviently locally ( make validate catched some errors and warning that we might wanna fix in another PR.)
Added terraform format recursive option in CI.
metaphore secrets are now created using a single vault_generic_secret block using for_each, so its less redundant

This PR is ready for review, would love some feedback if somebody has the time and patience

fharper commented 3 months ago

@FalcoSuessgott sorry for the wait, I was away, and the team is swamped. Thanks a lot for your contribution to kubefirst!

I'll ask the engineering team to review your PR, but can you please sign your commits please https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits as we won't be able to merge them without it.

FalcoSuessgott commented 3 months ago

Hi @fharper! aprreciate your time. Signed all commits now and rebased against main :)

fharper commented 3 months ago

Thanks @FalcoSuessgott: if you want to DM me on our Slack community, I'll send you some swag as a small thank you gesture for your PR!